Frontend Development Guidelines

This document describes various guidelines to ensure consistency and quality across the GitLab frontend team.

Overview

GitLab is built on top of Ruby on Rails. It uses Haml and a JavaScript-based frontend with Vue.js. If you are not sure when to use Vue on top of Haml-page, please read this explanation.

Be wary of the limitations that come with using Hamlit.

When it comes to CSS, we use a utils-based CSS approach. GitLab has its own CSS utils which are packaged inside the gitlab-ui project and can be seen in the repository or on UNPKG. Please favor using these before adding or using any SCSS classes.

We also use SCSS and plain JavaScript with modern ECMAScript standards supported through Babel and ES module support through webpack.

When making API calls, we use GraphQL as the first choice. There are still instances where GitLab REST API is used such as when creating new simple HAML pages or in legacy part of the codebase, but we should always default to GraphQL when possible.

Working with our frontend assets requires Node (v12.22.1 or greater) and Yarn (v1.10.0 or greater). You can find information on how to install these on our installation guide.

Vision

As Frontend engineers, we strive to give users delightful experiences. We should always think of how this applies at GitLab specifically: a great GitLab experience means helping our userbase ship their own projects faster and with more confidence when shipping their own software. This means that whenever confronted with a choice for the future of our department, we should remember to try to put this first.

Values

We define three core values, Stability, Speed and Maintainability (SSM)

Stability

Although velocity is extremely important, we believe that GitLab is now an enterprise-grade platform that requires even the smallest MVC to be stable, tested and with a good architecture. We should not merge code, even as an MVC, that could introduce degradation, poor performance, confusion or generally lower our users expectations.

This is an extension of the core value that want our users to have confidence in their own software and to do so, they need to have confidence in GitLab first. This means that our own confidence in our software should be at the absolute maximum.

Speed

Users should be able to navigate through the GitLab application with ease. This implies fast load times, easy to find pages, clear UX and an overall sense that they can accomplish their goal without friction.

Additionally, we want our speed to be felt and appreciated by our developers. This means that we should put a lot of effort and thoughts into processes, tools and documentation that help us achieve success faster across our department. This benefits us as engineers, but also our users that end up receiving quality features at a faster rate.

Maintainability

GitLab is now a large, enterprise-grade software and it often requires complex code to give the best possible experience. Although complexity is a necessity, we must remain vigilent to not let it grow more than it should. To minimize this, we want to focus on making our codebase maintainable by encapsulating complexity. This is done by:

  • Building tools that solve commonly-faced problems and making them easily discoverable.
  • Writing better documentation on how we solve our problems.
  • Writing loosly coupled components that can be easily added or removed from our codebase.
  • Remove older technologies or pattern that we deem are no longer acceptable.

By focusing on these aspects, we aim to allow engineers to contain complexity in well defined boundaries and quickly share them with their peers.

Goals

Now that our values have been defined, we can base our goals on these values and determine what we would like to achieve at GitLab with this in mind.

  • Lowest possible FID, LCP and cross-page navigation times
  • Minimal page reloads when interacting with the UI
  • Have as little Vue applications per page as possible
  • Leverage Ruby ViewComponents for simple pages and avoid Vue overhead when possible
  • Migrate existing VueX stores to Apollo, but more urgently stop using both together
  • Remove jQuery from our codebase
  • Add a visual testing framework
  • Reduce CSS bundle size to a minimum
  • Reduce cognitive overhead and improve maintainability of our CSS
  • Improve our pipelines speed
  • Build a better set of shared components with documentation

Frontend onboarding course

The Frontend onboarding course provides a 6-week structured curriculum to learn how to contribute to the GitLab frontend.

Browser Support

For supported browsers, see our requirements.

Use BrowserStack to test with our supported browsers. Sign in to BrowserStack with the credentials saved in the Engineering vault of the GitLab shared 1Password account.

Initiatives

You can find current frontend initiatives with a cross-functional impact on epics with the label frontend-initiative.

Principles

High-level guidelines for contributing to GitLab.

Development Process

How we plan and execute the work on the frontend.

Architecture

How we go about making fundamental design decisions in the GitLab frontend team or make changes to our frontend development guidelines.

Testing

How we write frontend tests, run the GitLab test suite, and debug test related issues.

Pajamas Design System

Reusable components with technical and usage guidelines can be found in our Pajamas Design System.

Design Patterns

JavaScript design patterns in the GitLab codebase.

Design Anti-patterns

JavaScript design anti-patterns we try to avoid.

Vue.js Best Practices

Vue specific design patterns and practices.

Vuex

Vuex specific design patterns and practices.

Axios

Axios specific practices and gotchas.

GraphQL

How to use GraphQL.

HAML

How to use HAML.

ViewComponent

How we use ViewComponent.

Icons and Illustrations

How we use SVG for our Icons and Illustrations.

Dependencies

General information about frontend dependencies and how we manage them.

Keyboard Shortcuts

How we implement keyboard shortcuts that can be customized and disabled.

Editors

GitLab text editing experiences are provided by the source editor and the rich text editor.

Frontend FAQ

Read the frontend’s FAQ for common small pieces of helpful information.

Style Guides

See the relevant style guides for our guidelines and for information on linting:

  • JavaScript. Our guide is based on the excellent Airbnb style guide with a few small changes.
  • SCSS: our SCSS conventions which are enforced through stylelint.
  • HTML. Guidelines for writing HTML code consistent with the rest of the codebase.
  • Vue. Guidelines and conventions for Vue code may be found here.

Tooling

Our code is automatically formatted with Prettier to follow our guidelines. Read our Tooling guide for more detail.

Performance

Best practices for monitoring and maximizing frontend performance.

Security

Frontend security practices.

Accessibility

Our accessibility standards and resources.

Logging

Best practices for client-side logging for GitLab frontend development.

Internationalization (i18n) and Translations

Frontend internationalization support is described in this document. The externalization part of the guide explains the helpers/methods available.

Troubleshooting

Running into a Frontend development problem? Check out this guide to help resolve your issue.